[IDE] Call into matchWitnessStructure to check if we should inherit a comment from an overridden declaration
#75666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
share-is-static
branch
from
c9ec1a5 to
51277bd
Compare
ahoppen
requested review from
bnbarham,
hamishknight,
rintaro,
QuietMisdreavus,
xymus,
AnthonyLatsis,
hborla,
slavapestov,
artemcm,
tshortli and
xedin
as code owners
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
share-is-static
branch
from
51277bd to
602827b
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
share-is-static
branch
2 times, most recently
from
49daaab to
ca3eb38
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
share-is-static
branch
from
ca3eb38 to
26a502c
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Aug 9, 2024
lib/Sema/TypeCheckProtocol.cpp
Outdated
| llvm::function_ref<RequirementMatch(bool, ArrayRef<OptionalAdjustment>)> | ||
| finalize) { | ||
|
|
||
| /// Implementation of `matchWitnessStructure` that also sets a few out paramter |
There was a problem hiding this comment.
Suggested change
| /// Implementation of `matchWitnessStructure` that also sets a few out paramter | |
| /// Implementation of `matchWitnessStructure` that also sets a few out parameters |
ahoppen
force-pushed
the
share-is-static
branch
from
26a502c to
3c85884
Compare
… from `AST` to `Sema` This allows use to re-use logic from Sema in those requests. This commit just moves functions around and does not change any functionality.
ahoppen
force-pushed
the
share-is-static
branch
from
3c85884 to
a04bf1d
Compare
|
@swift-ci Please smoke test |
… a comment from an overridden declaration
ahoppen
force-pushed
the
share-is-static
branch
from
a04bf1d to
f169bdb
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating logic whether a witness can match a requirement structurally (like static vs. non-static, matching decl kind etc.) call into the type checker to determine that.
This required moving
getDocCommentProvidingDeclandgetCascadingDocCommentfrom AST to IDE.Matching the type seemed to work fairly differently between the type checker and for IDE purposes, so we are not sharing that.