Skip to content

[cxx-interop] Remove -experimental-cxx-stdlib flag #76280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

egorzhdan
Copy link
Contributor

This flag was added back in 2020, but it didn't function properly, since a lot of other code in the compiler assumed the platform-default C++ stdlib until recently (#75589).

The recommended way to use a non-default C++ stdlib in Swift now is to pass -Xcc -stdlib=xyz argument to the compiler.

This change removes the -experimental-cxx-stdlib flag.

This flag was added back in 2020, but it didn't function properly, since a lot of other code in the compiler assumed the platform-default C++ stdlib until recently (#75589).

The recommended way to use a non-default C++ stdlib in Swift now is to pass `-Xcc -stdlib=xyz` argument to the compiler.

This change removes the `-experimental-cxx-stdlib` flag.
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 5, 2024
@egorzhdan egorzhdan requested a review from Xazax-hun September 5, 2024 14:21
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

egorzhdan added a commit to swiftlang/swift-driver that referenced this pull request Sep 5, 2024
@egorzhdan
Copy link
Contributor Author

@swift-ci please test Windows

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please test Windows

@egorzhdan egorzhdan merged commit 5490c50 into main Sep 6, 2024
3 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/remove-cxx-stdlib-flag branch September 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants