[Windows] Teach Build-Testing how to find Foundation #76489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift-testing#693 |
|
swiftlang/swift-testing#693 |
rintaro
changed the title
Pass `Foundation_DIR` to the cmake.
rintaro
force-pushed
the
windows-testing-foundationdir
branch
from
5bcca25 to
ff0f923
Compare
|
swiftlang/swift-testing#693 |
|
swiftlang/swift-testing#693 |
2 similar comments
|
swiftlang/swift-testing#693 |
|
swiftlang/swift-testing#693 |
|
swiftlang/swift-testing#693 |
1 similar comment
|
swiftlang/swift-testing#693 |
|
swiftlang/swift-testing#693 |
compnerd
approved these changes
Sep 17, 2024
| @@ -1934,6 +1936,8 @@ function Build-Testing([Platform]$Platform, $Arch, [switch]$Test = $false) { | |||
| -Defines (@{ | |||
| BUILD_SHARED_LIBS = "YES"; | |||
| CMAKE_BUILD_WITH_INSTALL_RPATH = "YES"; | |||
| dispatch_DIR = "$DispatchBinaryCache\cmake\modules"; | |||
| Foundation_DIR = "$FoundationBinaryCache\cmake\modules"; | |||
| SwiftSyntax_DIR = (Get-HostProjectCMakeModules Compilers); | |||
There was a problem hiding this comment.
This seems suspect! But this is outside of your change I suppose.
This was referenced Sep 18, 2024
bnbarham
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
Foundation_DIRto the CMake configuration.