Skip to content

Conversation

@kubamracek
Copy link
Contributor

Under arm64e ptrauth, we need to be more diligent on:

  • (1) The "minimal value witness table" that IRGen generates for task_create (ResultTypeInfoTaskOptionRecord) needs its function pointers to be signed. This PR uses the same signing scheme as regular Swift's value witness tables, i.e. address-discriminated pointers with special values per witness index (e.g. SpecialPointerAuthDiscriminators::InitializeWithCopy).

  • (2) Accessing HeapObject's metadata, which under Embedded Swift is not actually a ClassMetadata object.

rdar://138814877

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@al45tair
Copy link
Contributor

CMake Error at /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/llvm-project/libcxx/CMakeLists.txt:70 (message):
  Unsupported hardening mode: 'unchecked'.  Supported values are
  none;fast;extensive;debug.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubamracek kubamracek merged commit 8f66bf1 into swiftlang:main Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants