Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REQUIRES: aarch64 for dropped-var.sil test #78131

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

rastogishubham
Copy link
Contributor

@rastogishubham rastogishubham commented Dec 12, 2024

rdar://141272451 (🟠 OSS Swift CI: oss-swift_tools-RA_stdlib-DA_test-device-non_executable failed: test: DebugInfo/dropped-var.sil (exit code 1))

The dropped-var.sil test fails on watchos-armv7k with the following error:

SOURCE_DIR/test/DebugInfo/dropped-var.sil:36:43: error: value '%5' defined with mismatching type 'Builtin.Int32' (expected 'Builtin.Int64')

This is not true on other architecture, so I am guarding the test with a REQUIRES:CPU=aarch64

https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-device-non_executable/8009/consoleText

@rastogishubham rastogishubham changed the title Add REQUIRES: aarch64 for dropped-var.ll test Add REQUIRES: aarch64 for dropped-var.sil test Dec 12, 2024
@rastogishubham
Copy link
Contributor Author

@swift-ci please smoke test

@rastogishubham
Copy link
Contributor Author

@swift-ci please smoke test linus

@rastogishubham
Copy link
Contributor Author

@swift-ci please smoke test

@adrian-prantl
Copy link
Contributor

You might now still need to REQUIRE that the aarch64 target was built, but at least it's no longer depending on the host CPU type

@rastogishubham
Copy link
Contributor Author

@swift-ci please smoke test

@rastogishubham rastogishubham merged commit 06b16de into swiftlang:main Dec 13, 2024
3 checks passed
@rastogishubham rastogishubham deleted the FixTestDropped branch December 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants