Some general fixes to make it more system compatable and easier to use #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are several unrelated changes conflated together, please split them out into separate patches. The change from python to python2 for example, should be discussed separately. Thanks for your interest though! |
dabelknap
pushed a commit
to dabelknap/swift
that referenced
this pull request
Aug 2, 2018
dabelknap
pushed a commit
to dabelknap/swift
that referenced
this pull request
Sep 17, 2018
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
API: allow SyntaxNodes to check whether they are syntax collection
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Cperf fixes oct 2 cont'd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix a couple of Issues i encountered while first trying to build swift.
The first was copying and pasting git clone lines from the readme which is fixed by 4e510ba which replaces the ssh clone lines with https ones, removing the requirement to have set up ssh keys with github.
The second was it not building when python3 was the default python environment on the system, as it is under ArchLinux. 7c972d1 replaces all the hashbangs on python files with
#!/usr/bin/env python2which is believe is correct on all systems.The final commit, 5aa75d6, add the temporary CMake files to .gitignore so they are not accidentally committed at some point.