Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed urls for cloning repositories #80

Closed
wants to merge 1 commit into from

Conversation

AndreasPrang
Copy link

No description provided.

@oblitum
Copy link

oblitum commented Dec 3, 2015

Isn't the current setting correct? I've cloned without problems and have never seen slash as user separator in git urls.

@tkremenek
Copy link
Member

These URLs were recently changed (today) in 5ba5baf:

Author: Steve Klabnik steve@steveklabnik.com
Date: Thu Dec 3 12:23:31 2015 -0500

Remove extra / in git commands in README

This works, but is usually not how it's written. A command later in the
README was already using this style.

These URLs clone just fine. Is there an actual problem with them?

@AndreasPrang
Copy link
Author

It wasn't working for me. What should be the ":apple" string be for?
@krememek: In 5ba5baf the changes has been false.

github.com:/apple was correct.
github.com:apple is an invalide URL.

:/path is optional for :80/path

@mxcl
Copy link

mxcl commented Dec 3, 2015

We should use the https URLs since they don’t require an entire SSH keychain to be set up on user computers.

@oblitum
Copy link

oblitum commented Dec 3, 2015

Agree with @mxcl, it's the easier route in any case, although the current git urls look fine.

@AndreasPrang
Copy link
Author

@mxcl I added this in Pullrequest #82

@oblitum
Copy link

oblitum commented Dec 3, 2015

@AndreasPrang for sake of information, you could have amended this one already instead (adding a new commit on top or just force commiting).

@jsjohnst
Copy link

jsjohnst commented Dec 3, 2015

@AndreasPrang your version certainly doesn't work, what was there does...

$  git clone git@github.com/apple/swift.git swift
fatal: repository 'git@github.com/apple/swift.git' does not exist
$  git clone git@github.com:apple/swift.git swift
Cloning into 'swift'...
remote: Counting objects: 290256, done.
remote: Total 290256 (delta 0), reused 0 (delta 0), pack-reused 290256
Receiving objects: 100% (290256/290256), 55.79 MiB | 13.13 MiB/s, done.
Resolving deltas: 100% (237379/237379), done.
Checking connectivity... done.
Checking out files: 100% (9387/9387), done.

Link to docs to emphasize point: https://git-scm.com/book/ch4-1.html#The-SSH-Protocol

@noamtamim
Copy link

@AndreasPrang @jsjohnst Don't work so hard deciphering docs; just take a look at GitHub's clone URL for this repo:

HTTPS: https://github.com/apple/swift.git
SSH:       git@github.com:apple/swift.git

That colon between github.com and apple is what you always use with ssh URLs, like with scp/rsync.

Also note that HTTPS is the method recommended by GitHub.

@jsjohnst
Copy link

jsjohnst commented Dec 3, 2015

@noamtamim I know how to use Git, so didn't need to work hard deciphering docs. I'm linking @AndreasPrang so he can learn the proper way and not make borked pull requests on highly viewed repos.

@yurikoles
Copy link

@AndreasPrang please cancel this PR, since it's wrong and a total waste of time.

DougGregor added a commit to DougGregor/swift that referenced this pull request Apr 20, 2017
Address ABI FIXMEs swiftlang#28, swiftlang#80, swiftlang#81 by making the SubSequence of a filtered
collection into be a filtered collection of the base's
SubSequence rather than a slice of this filtered collection, e.g.,
replace `Slice<LazyFilterCollection<Array<T>>>` with
`LazyFilterCollection<ArraySlice<T>>`, which allows slicing
optimizations of the base type to kick in.

While here, eliminate the vestigial type `LazyFilterIndex`, which was
necessary pre-Swift-3 to allow the index to move. Swift 3's indexing
model means that the movement of indices is on the collection itself,
so we no longer need `LazyFilterIndex`: instead, the `Index` type of
the lazy filtered collection is simply the `Index` type of the base
collection, which is a nice convenience: it means you can take indices
from a lazy wrapper around a given collection C and use them with the
collection C (and, with care, vice-versa) without jumping through
extra hoops.
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Jul 17, 2018
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Sep 17, 2018
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024
Update the RPM spec files to support release/5.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants