-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed urls for cloning repositories #80
Conversation
Isn't the current setting correct? I've cloned without problems and have never seen slash as user separator in git urls. |
These URLs were recently changed (today) in 5ba5baf: Author: Steve Klabnik steve@steveklabnik.com
These URLs clone just fine. Is there an actual problem with them? |
It wasn't working for me. What should be the ":apple" string be for? github.com:/apple was correct. :/path is optional for :80/path |
We should use the |
Agree with @mxcl, it's the easier route in any case, although the current git urls look fine. |
@AndreasPrang for sake of information, you could have amended this one already instead (adding a new commit on top or just force commiting). |
@AndreasPrang your version certainly doesn't work, what was there does...
Link to docs to emphasize point: https://git-scm.com/book/ch4-1.html#The-SSH-Protocol |
@AndreasPrang @jsjohnst Don't work so hard deciphering docs; just take a look at GitHub's clone URL for this repo:
That colon between github.com and apple is what you always use with ssh URLs, like with scp/rsync. Also note that HTTPS is the method recommended by GitHub. |
@noamtamim I know how to use Git, so didn't need to work hard deciphering docs. I'm linking @AndreasPrang so he can learn the proper way and not make borked pull requests on highly viewed repos. |
@AndreasPrang please cancel this PR, since it's wrong and a total waste of time. |
Address ABI FIXMEs swiftlang#28, swiftlang#80, swiftlang#81 by making the SubSequence of a filtered collection into be a filtered collection of the base's SubSequence rather than a slice of this filtered collection, e.g., replace `Slice<LazyFilterCollection<Array<T>>>` with `LazyFilterCollection<ArraySlice<T>>`, which allows slicing optimizations of the base type to kick in. While here, eliminate the vestigial type `LazyFilterIndex`, which was necessary pre-Swift-3 to allow the index to move. Swift 3's indexing model means that the movement of indices is on the collection itself, so we no longer need `LazyFilterIndex`: instead, the `Index` type of the lazy filtered collection is simply the `Index` type of the base collection, which is a nice convenience: it means you can take indices from a lazy wrapper around a given collection C and use them with the collection C (and, with care, vice-versa) without jumping through extra hoops.
Make `SyntaxKind` internal
Cperf fixes oct 3
Update the RPM spec files to support release/5.6
No description provided.