[Debug Info] Add missing caching for types with no type sugar #80179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBuilder::replaceTemporary() can return a different pointer. In practice this only happens when temporary and replacement are uniqued, so that's probably how we got away with this in the past.
when creating the members of a struct, to avoid problems when the type graph changes due to type nodes being uniqued. It's not clear this can actually happen, but it helps ruling this out as a failure cause.
This avoids redundant creation and uniquing of types in the case where we only have a canonical name. Since the uniquing changes the type graph this introduced the possibility for use-after-free if IRGenDebugInfoImpl held on to a direct (non-tracking) DIType *. rdar://146327709
|
@swift-ci test |
augusto2112
approved these changes
Mar 20, 2025
|
The reason I didn't bother reducing the type out of the crashing program is that the assertion is an even stronger precondition for the use-after-free and we already trigger it with two tests in the existing test suite. |
|
@swift-ci test macos |
|
@swift-ci please test source compatibility |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids redundant creation and uniquing of types in the case where
we only have a canonical name. Since the uniquing changes the type
graph this introduced the possibility for use-after-free if
IRGenDebugInfoImpl held on to a direct (non-tracking) DIType *.
rdar://146327709
depends on #80170