[SILOptimizer] Prevent devirtualization of call to distributed witnes… #80373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
approved these changes
Mar 28, 2025
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
xedin
force-pushed
the
rdar-146101172-narrow
branch
from
0415b40 to
c99f72b
Compare
|
@swift-ci please test |
|
@swift-ci benchmark |
…s requirements This is a narrow fix, we are going to work on fixing this properly and allowing both devirtualization and specialization for distributed requirement witnesses. Anything that uses an ad-hoc serialization requirement scheme cannot be devirtualized because that would result in loss of ad-hoc conformance in new substitution map. Resolves: swiftlang#79318 Resolves: rdar://146101172
xedin
force-pushed
the
rdar-146101172-narrow
branch
from
c99f72b to
585b687
Compare
|
@swift-ci benchmark |
|
@swift-ci please test |
xedin
commented
Mar 30, 2025
| // REQUIRES: concurrency | ||
| // REQUIRES: distributed | ||
|
|
||
| // REQUIRES: OS=macosx || OS=ios |
There was a problem hiding this comment.
@ktoso FYI, I restricted this test to macOS and iOS only for now because it fails with availability issues on watch os:
/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/Distributed/distributed_actor_adhoc_requirements_optimized_build.swift:56:17: error: 'RemoteCallArgument' is only available in watchOS 9.0 or newer
50 |
51 | // NOT final on purpose
52 | public class FakeInvocationEncoder : DistributedTargetInvocationEncoder {
| `- note: add @available attribute to enclosing class
53 | public typealias SerializationRequirement = Transferable
54 |
55 | public func recordArgument<Value: SerializationRequirement>(
| `- note: add @available attribute to enclosing instance method
56 | _ argument: RemoteCallArgument<Value>) throws {
| `- error: 'RemoteCallArgument' is only available in watchOS 9.0 or newer
57 | }
58 |
/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/Distributed/distributed_actor_adhoc_requirements_optimized_build.swift:83:31: error: 'DistributedActor' is only available in watchOS 9.0 or newer
71 |
72 | // NOT final on purpose
73 | public class NotFinalActorSystemForAdHocRequirementTest: DistributedActorSystem, @unchecked Sendable {
| `- note: add @available attribute to enclosing class
74 | public typealias ActorID = String
75 | public typealias InvocationEncoder = FakeInvocationEncoder
:
80 | public init() {}
81 |
82 | public func resolve<Act>(id: ActorID, as actorType: Act.Type)
| `- note: add @available attribute to enclosing instance method
83 | throws -> Act? where Act: DistributedActor {
| `- error: 'DistributedActor' is only available in watchOS 9.0 or newer
84 | fatalError()
85 | }
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s requirements
This is a narrow fix, we are going to work on fixing this properly and allowing both devirtualization and specialization for distributed requirement witnesses.
Anything that uses an ad-hoc serialization requirement scheme cannot be devirtualized because that would result in loss of ad-hoc conformance in new substitution map.
Resolves: #79318
Resolves: rdar://146101172