SIL: Tiny conformance substitution cleanups #80594
Conversation
slavapestov
requested review from
xymus,
eeckstein,
jckarter and
rjmccall
as code owners
| @@ -71,9 +71,8 @@ public struct WitnessTable : CustomStringConvertible, NoReflectionChildren { | |||
| OptionalBridgedFunction(obj: witness?.bridged.obj)) | |||
| case .associatedType(let requirement, let witness): | |||
| return BridgedWitnessTableEntry.createAssociatedType(requirement.bridged, witness.bridged) | |||
| case .associatedConformance(let requirement, let substType, let witness): | |||
There was a problem hiding this comment.
@eeckstein I was lazy but the substType tuple element can be removed from this enum case entirely now.
There was a problem hiding this comment.
Can you remove the enum case in this PR? Shouldn't be too much work.
There was a problem hiding this comment.
Done. (it's a tuple field in an enum case, not the whole enum case that I removed.)
slavapestov
force-pushed
the
sil-abstract-conformance-cleanup
branch
2 times, most recently
from
5bb42c3 to
99cd4bd
Compare
| return; | ||
| makeAlive(WT); | ||
|
|
||
| // FIXME: If 'concrete' is a SpecializedProtocolConformance, |
There was a problem hiding this comment.
@eeckstein Thoughts?
There was a problem hiding this comment.
It actually doesn't matter because we don't do dead witnesstable elimination. In findAnchorsInTables we set all witness tables alive. We had to do this because it's almost impossible to find all references to witness tables in SIL. Only IRGen knows that - and we emit witness tables lazily there.
There was a problem hiding this comment.
Ah. I'll just delete the logic then since it's pointless to keep around code that is unused and incorrect.
| @@ -71,9 +71,8 @@ public struct WitnessTable : CustomStringConvertible, NoReflectionChildren { | |||
| OptionalBridgedFunction(obj: witness?.bridged.obj)) | |||
| case .associatedType(let requirement, let witness): | |||
| return BridgedWitnessTableEntry.createAssociatedType(requirement.bridged, witness.bridged) | |||
| case .associatedConformance(let requirement, let substType, let witness): | |||
There was a problem hiding this comment.
Can you remove the enum case in this PR? Shouldn't be too much work.
| return; | ||
| makeAlive(WT); | ||
|
|
||
| // FIXME: If 'concrete' is a SpecializedProtocolConformance, |
There was a problem hiding this comment.
It actually doesn't matter because we don't do dead witnesstable elimination. In findAnchorsInTables we set all witness tables alive. We had to do this because it's almost impossible to find all references to witness tables in SIL. Only IRGen knows that - and we emit witness tables lazily there.
slavapestov
force-pushed
the
sil-abstract-conformance-cleanup
branch
2 times, most recently
from
0625b16 to
f7fc125
Compare
This logic was unconditionally disabled and incorrect.
slavapestov
force-pushed
the
sil-abstract-conformance-cleanup
branch
from
f7fc125 to
be5d03f
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci benchmark |
Follow-up to #80482 that removes origType plumbing from a few more places in SIL.