Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2] [Sema] Requestify PatternBindingDecl capture computation #80599

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #80535

  • Explanation: Fixes a crash that could occur when introducing a stored property to a type using a macro
  • Scope: Affects macro expansions for stored properties
  • Issue: rdar://143429551
  • Risk: Low/Medium, applies existing logic to more cases
  • Testing: Added tests to test suite
  • Reviewer: Slava Pestov

Introduce `PatternBindingCaptureInfoRequest`, and kick it after
contextualizing a property initializer. This ensures it gets run
for stored properties added by macro expansions.

rdar://143429551
The initializer for a lazy property is always subsumed, so we should
have already bailed.
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Apr 7, 2025
@hamishknight hamishknight requested a review from bnbarham April 7, 2025 16:36
@hamishknight hamishknight requested a review from a team as a code owner April 7, 2025 16:36
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight enabled auto-merge April 7, 2025 18:33
@hamishknight hamishknight merged commit e8c85fa into swiftlang:release/6.2 Apr 8, 2025
5 checks passed
@hamishknight hamishknight deleted the cap-req-6.2 branch April 8, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants