Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency: Move code between Executor{Bridge,Impl}.cpp #80601

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Apr 7, 2025

New ExecutorImpl.cpp is excluded when building Embedded Swift stdlib. This fixes duplicate symbol errors when using Embedded Swift and libswift_ConcurrencyDefaultExecutor.a.

This fixes duplicate symbol errors when using Embedded Swift
@MaxDesiatov MaxDesiatov added Concurrencу Area → standard library: The `Concurrency` module under the standard library umbrella embedded Embedded Swift labels Apr 7, 2025
@MaxDesiatov MaxDesiatov requested review from bnbarham and al45tair April 7, 2025 17:43
@MaxDesiatov MaxDesiatov requested a review from ktoso as a code owner April 7, 2025 17:43
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci build toolchain

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) April 8, 2025 10:31
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

@al45tair
Copy link
Contributor

al45tair commented Apr 8, 2025

This fixes duplicate symbol errors when using Embedded Swift.

…when using libswift_ConcurrencyDefaultExecutor.a. It was fine without that.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

@MaxDesiatov MaxDesiatov merged commit ccd9cf7 into main Apr 9, 2025
6 of 7 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/fix-executor-impl branch April 9, 2025 12:36
artemcm added a commit that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concurrencу Area → standard library: The `Concurrency` module under the standard library umbrella embedded Embedded Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants