Add a platform executor module for OpenBSD. #80877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test. |
|
@swift-ci please test Linux platform. |
|
@ktoso just a ping if you could take a look? This should be relatively uncontroversial. |
al45tair
reviewed
Apr 25, 2025
| @@ -164,6 +164,7 @@ set(SWIFT_RUNTIME_CONCURRENCY_SWIFT_SOURCES | |||
| PlatformExecutorDarwin.swift | |||
| PlatformExecutorLinux.swift | |||
| PlatformExecutorWindows.swift | |||
| PlatformExecutorOpenBSD.swift | |||
There was a problem hiding this comment.
This change also needs making in the CMakeLists.txt in the Runtimes/Core/Concurrency directory (see https://github.com/swiftlang/swift/tree/main/Runtimes/Core/Concurrency).
This is basically the same as the one for Linux, but it would be somewhat awkward to add the platform conditional on a file named for Linux when OpenBSD is not Linux. Important note: if Dispatch is disabled, then this will cause a compilation error (probably not just for OpenBSD either), because PlatformExecutorFactory is both defined in PlatformExecutorNone.swift and PlatformExecutor<...>.swift in this case. Because this only bites OpenBSD bootstrap builds, and since OpenBSD support has been upstreamed to Dispatch, default to the Dispatch implementation for now to get this in, and we'll refactor in a different pr.
3405691582
force-pushed
the
platform_executor
branch
from
495355d to
db942de
Compare
3405691582
requested review from
etcwilde,
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please test. |
compnerd
approved these changes
Apr 26, 2025
|
@swift-ci please test macOS platform. |
|
Please merge on my behalf if we are good, thank you! |
etcwilde
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same as the one for Linux, but it would be somewhat awkward to add the platform conditional on a file named for Linux when OpenBSD is not Linux.
Important note: if Dispatch is disabled, then this will cause a compilation error (probably not just for OpenBSD either), because PlatformExecutorFactory is both defined in PlatformExecutorNone.swift and PlatformExecutor<...>.swift in this case.
Because this only bites OpenBSD bootstrap builds, and since OpenBSD support has been upstreamed to Dispatch, default to the Dispatch implementation for now to get this in, and we'll refactor in a different pr.