Skip to content

[validation-test] Add line-directive doctests #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gribozavr merged 2 commits into from
Dec 29, 2015
Merged

[validation-test] Add line-directive doctests #810

gribozavr merged 2 commits into from
Dec 29, 2015

Conversation

@modocache
Copy link
Contributor

@modocache modocache commented Dec 29, 2015

What's in this pull request?

This adds the standard Python code header to utils/line-directive. It also adds that script's tests to the validation-test targets.

Why merge this pull request?

  • It makes the script more consistent with the rest of the Python code in the Swift codebase.
  • It adds the proper copyright to the file.
  • It ensures the tests for this file pass, without requiring developers to run them manually.

What downsides are there to merging this pull request?

  • There's only a single doctest in utils/line-directive. It's not a very robust test suite in the first place, so the value of adding it to validation-test is questionable.
  • One could argue that a code header should be added to all Python files in the codebase at once, in a single commit. I'm not doing so here because I happened upon this file when using it, and decided to send a quick pull request, instead of trying to find all the remaining Python in this repository.

@modocache
[line-directive] Add code header
0d62ed2 
Add code headers missing from `utils/line-directive`, as per the template
from swiftlang#762.
@modocache
[validation-test] Add line-directive doctests
57380fa 
`utils/line-directive` is used when building Swift (see
`cmake/modules/AddSwift.cmake`), and includes some doctests. In order
to make sure it continues to behave as intended, add its tests to
`validation-test`.
gribozavr added a commit that referenced this pull request Dec 29, 2015
@gribozavr
Merge pull request #810 from modocache/add-line-directive-tests-to-build
8338233 
[validation-test] Add line-directive doctests
@gribozavr gribozavr merged commit 8338233 into swiftlang:master Dec 29, 2015
@gribozavr
Copy link
Contributor

gribozavr commented Dec 29, 2015

@modocache Thank you!

@modocache modocache deleted the add-line-directive-tests-to-build branch December 29, 2015 06:33
@modocache modocache mentioned this pull request Feb 1, 2016
Merged
@KingOfBrian KingOfBrian mentioned this pull request Mar 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@modocache @gribozavr