Skip to content

Conversation

AnthonyLatsis
Copy link
Collaborator

No description provided.

@AnthonyLatsis

This comment was marked as duplicate.

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you

@bnbarham
Copy link
Contributor

bnbarham commented May 2, 2025

@aschwaighofer do we actually care about checking for captures(none) and nuw? I mostly ask because it would be nice if we could avoid main conflicts here, which we could do if we used {{.*}} rather than the actual checks.

@AnthonyLatsis AnthonyLatsis changed the title [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again May 4, 2025
@@ -24,7 +24,7 @@ func foo(_ x: inout Int64) {
// IRCHECK-NEXT: call void @llvm.memset.{{.*}}(ptr align {{(4|8)}} %[[X]], i8 0
// IRCHECK: store ptr %0, ptr %[[X]], align {{(4|8)}}
// IRCHECK-SAME: !dbg ![[LOC0:.*]]
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds %Ts5Int64V, ptr %0, i32 0, i32 0,
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds nuw %Ts5Int64V, ptr %0, i32 0, i32 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 2 times, most recently from f36c739 to 5e79ea5 Compare May 8, 2025 08:14
@AnthonyLatsis AnthonyLatsis changed the title [DNM] [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again (part 2) May 8, 2025
@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 3 times, most recently from a008ec9 to 20d38f9 Compare May 9, 2025 14:34
@AnthonyLatsis AnthonyLatsis marked this pull request as draft May 20, 2025 17:57
@AnthonyLatsis AnthonyLatsis changed the title [DNM] [rebranch] Adjust some tests to pass again (part 2) [DNM] Rebranch testing Jun 27, 2025
@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#11515

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test macOS

@shahmishal shahmishal deleted the branch swiftlang:rebranch October 3, 2025 03:17
@shahmishal shahmishal closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants