Skip to content

[DNM] [rebranch] Adjust some tests to pass again (part 2) #81190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rebranch
Choose a base branch
from
Open

[DNM] [rebranch] Adjust some tests to pass again (part 2) #81190

wants to merge 1 commit into from

Conversation

AnthonyLatsis
Copy link
Collaborator

No description provided.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis AnthonyLatsis requested a review from bnbarham April 30, 2025 06:54
@AnthonyLatsis

This comment was marked as duplicate.

Sign in to view
1 similar comment
@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#10599

@swift-ci please smoke test macOS

aschwaighofer
aschwaighofer approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you

@bnbarham
Copy link
Contributor

bnbarham commented May 2, 2025

@aschwaighofer do we actually care about checking for captures(none) and nuw? I mostly ask because it would be nice if we could avoid main conflicts here, which we could do if we used {{.*}} rather than the actual checks.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test macOS

@AnthonyLatsis AnthonyLatsis mentioned this pull request May 4, 2025
Merged
@AnthonyLatsis AnthonyLatsis changed the title [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again May 4, 2025
adrian-prantl
adrian-prantl reviewed May 5, 2025
View reviewed changes
test/DebugInfo/shadowcopy-linetable.swift Outdated
@@ -24,7 +24,7 @@ func foo(_ x: inout Int64) {
// IRCHECK-NEXT: call void @llvm.memset.{{.*}}(ptr align {{(4|8)}} %[[X]], i8 0
// IRCHECK: store ptr %0, ptr %[[X]], align {{(4|8)}}
// IRCHECK-SAME: !dbg ![[LOC0:.*]]
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds %Ts5Int64V, ptr %0, i32 0, i32 0,
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds nuw %Ts5Int64V, ptr %0, i32 0, i32 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Linux

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis AnthonyLatsis mentioned this pull request May 8, 2025
Merged
@AnthonyLatsis AnthonyLatsis changed the title [DNM] [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again (part 2) May 8, 2025
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham left review comments

@adrian-prantl adrian-prantl adrian-prantl left review comments

@aschwaighofer aschwaighofer aschwaighofer approved these changes

@eeckstein eeckstein Awaiting requested review from eeckstein

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro is a code owner

@hnrklssn hnrklssn Awaiting requested review from hnrklssn hnrklssn is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall

@ktoso ktoso Awaiting requested review from ktoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnthonyLatsis @bnbarham @adrian-prantl @aschwaighofer