[Observation] Restrict deinitialization fired events to be limited to one per registrar and send a \Self.self as the keypath to avoid property confusions #82307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phausler
force-pushed
the
pr/observation_deinit_trigger_reduction
branch
from
83e6f32 to
473c5b5
Compare
… one per registrar and send a \Self.self as the keypath to avoid property confusions
phausler
force-pushed
the
pr/observation_deinit_trigger_reduction
branch
from
473c5b5 to
071d5b5
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
jamieQ
reviewed
Jun 18, 2025
| tracker = { | ||
| found(selfKp) | ||
| } | ||
| break |
There was a problem hiding this comment.
is this supposed to break from just the inner loop and then potentially overwrite the tracker variable on a subsequent iteration?
There was a problem hiding this comment.
yea, that would be a performance improvement
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
stephentyrone
pushed a commit
that referenced
this pull request
Jul 10, 2025
…e observations in memory (#82752) Explanation: This ensures a potential leak with SwiftUI and other systems using Observation do not leak observation closures when the potential Observable instances used are only weakly referenced inside the tracking closure. Scope: This is limited to the runtime behavior of Observable types and has no ABI or language level interactions. Issues: rdar://112167556 Original PRs: #79823 #82307 Risk: Low - This is very targeted to just Observation, however it is a behavioral change which does not make this a zero risk change. Testing: New unit tests were added to catch at least some of the potential cases this issue can occur with.
stephentyrone
approved these changes
Jul 11, 2025
|
@swift-ci smoke test linux |
|
shall this be merged since the 6.2 version of it already has been? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the deinitialization triggering of observation is limited to one willSet/onChange event and that keypath that is claimed for that change is then
\Self.selfThis resolves rdar://153655165