[RemoteInspection] Change RemoteAbsolutePointer (NFC) #82325
+46
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test with swiftlang/llvm-project#10865 |
augusto2112
approved these changes
Jun 18, 2025
| @@ -1871,7 +1871,7 @@ class TypeRefBuilder { | |||
| if (auto symbol = OpaquePointerReader( | |||
| remote::RemoteAddress(adjustedProtocolDescriptorTarget), | |||
| PointerSize)) { | |||
| if (!symbol->getSymbol().empty()) { | |||
| if (!symbol->getSymbol().empty() && symbol->getOffset() == 0) { | |||
There was a problem hiding this comment.
Why must the offset be 0 in this case?
There was a problem hiding this comment.
According to the other comments the combination of Symbol+Offset isn't actually implemented.
There was a problem hiding this comment.
I just took this for granted without further investigation, but given that the Offset is never taken here, it seems plausible.
This patch changes RemoteAbsolutePointer to store both the symbol and the resolved address. This allows us to retire some ugly workarounds to deal with non-symbolic addresses and it fixes code paths that would need these workarounds, but haven't implemented them yet (i.e., the pack shape handling in the symbolicReferenceResolver in MetadatyaReader. Addresses parts of rdar://146273066. rdar://153687085
|
test with swiftlang/llvm-project#10865 |
|
test with swiftlang/llvm-project#10865 |
|
test with swiftlang/llvm-project#10865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes RemoteAbsolutePointer to store both the symbol and the resolved address. This allows us to retire some ugly workarounds to deal with non-symbolic addresses and it fixes code paths that would need these workarounds, but haven't implemented them yet (i.e., the pack shape handling in the symbolicReferenceResolver in MetadataReader.
Addresses parts of rdar://146273066.
rdar://153687085