InstructionSimplification: simplify negated integer comparisons #82804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
changed the title
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
eeckstein
force-pushed
the
simplify_negated_comparisons
branch
from
d7e4213 to
a33cfae
Compare
eeckstein
force-pushed
the
simplify_negated_comparisons
branch
from
a33cfae to
d429bad
Compare
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
eeckstein
force-pushed
the
simplify_negated_comparisons
branch
from
d429bad to
b4d7b68
Compare
|
@swift-ci test |
So far, only negated comparisons (via xor) were handled. Now, also handle simplified comparisons
That means: make `BuiltinInst` conform to `SILCombineSimplifiable`, but still also run the legacy builtin simplification in SILCombine
Replaces a builtin "xor", which negates its operand comparison ``` %3 = builtin "cmp_slt_Int64"(%1, %2) : $Builtin.Int1 %4 = integer_literal $Builtin.Int1, -1 %5 = builtin "xor_Int1"(%3, %4) : $Builtin.Int1 ``` with the negated comparison ``` %5 = builtin "cmp_ge_Int64"(%1, %2) : $Builtin.Int1 ``` This makes LLVM's IPSCCP happy. rdar://154950810
eeckstein
force-pushed
the
simplify_negated_comparisons
branch
from
b4d7b68 to
5064297
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
1 similar comment
|
@swift-ci smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces a builtin "xor", which negates its operand comparison
with the negated comparison
This makes LLVM's IPSCCP happy.
rdar://154950810