[6.2] SILGen: Bitcast indirect returns that differ only in concurrency annotations. #82916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tations. A call to a `@preconcurrency` function goes through a function conversion that removes `Sendable` from existentials among other things. Implement support for this by bitcasting indirect return slots whose type differs from the formal indirect return type in concurrency markings only. Fixes rdar://154240007
|
@swift-ci Please test |
tbkka
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a compiler crash when a function returning
any Sendableor(any Sendable)?is called through a@preconcurrencyinterface.Scope: Fixes a regression introduced by new concurrency behavior.
Issue: rdar://154240007
Original PRs: #82901
Risk: Low. Changes behavior to fix a bug in a limited situation where
@preconcurrencycode tries to call a function returningany Sendableor some other indirectly-returned type.Testing: Swift CI, test case from bug report
Reviewers: @xedin