[cxx-interop] Do not consider extensions blessed by SWIFT_PRIVATE_FILEID to be retroactive #83387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EID to be retroactive Swift warns users when they conform an imported type to an imported protocol, because such retroactive conformances are prone to producing conflicting conformances in multiple modules. When a user annotates a class as SWIFT_PRIVATE_FILEID, they are explicitly conveying that extensions in the blessed file are part of the class's private implementation (and thus privy to elevated access), so we should also not treat conformances in that file as retroactive. This patch fixes that and adds a test case. rdar://148083096
j-hui
requested review from
Xazax-hun,
egorzhdan,
fahadnayyar,
hnrklssn,
slavapestov,
susmonteiro and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please test |
Xazax-hun
approved these changes
Jul 29, 2025
egorzhdan
approved these changes
Jul 29, 2025
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift warns users when they conform an imported type to an imported protocol, because such retroactive conformances are prone to producing conflicting conformances in multiple modules.
When a user annotates a class as SWIFT_PRIVATE_FILEID, they are explicitly conveying that extensions in the blessed file are part of the class's private implementation (and thus privy to elevated access), so we should also not treat conformances in that file as retroactive.
This patch fixes that and adds a test case.
rdar://148083096