Don't grow smol Strings to 16 characters when bridging out if tagged pointer formation fails #84068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pointer formation fails
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please Apple Silicon benchmark |
Catfish-Man
commented
Sep 3, 2025
| if _guts.isSmallASCII { | ||
| let maybeTagged = _guts.asSmall.withUTF8 { bufPtr in | ||
| return unsafe _createCFString( | ||
| if _guts.isSmall { |
Contributor
Author
There was a problem hiding this comment.
This is mostly just rearranging the code to be a bit clearer. The substantive change is is switching from grow + recursing into bridgeToObjectiveCImpl -> __StringStorage.create, which should let us create the actual size we want rather than unnecessarily padded.
Contributor
Author
|
15% or so win for ObjectiveCBridgeStubToNSString. Honestly better than I expected. |
Contributor
Author
|
docc failure is unrelated, will rerun tests once it's fixed |
stephentyrone
approved these changes
Sep 3, 2025
glessard
approved these changes
Sep 3, 2025
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://159771498