-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Win smoke tests #84770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Win smoke tests #84770
Conversation
|
Can we move the Dockerfile to https://github.com/swiftlang/swift-docker? |
|
@swift-ci please build toolchain Windows platform |
|
@swift-ci please build toolchain Windows platform |
| Write-Host "Starting smoke test" | ||
| Write-Host "" | ||
|
|
||
| swift --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: can we inspect the output and ensure it's not empty? I'm asking is this would not have caught the issue reported by:
| Set-Location $CloneDir | ||
|
|
||
| Write-Host "Building swift-win32" | ||
| swift build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: can we inspect the output and ensure it's not empty? I'm asking is this would not have caught the issue reported by:
| Write-Host "" | ||
|
|
||
| Write-Host "Testing swift-win32" | ||
| swift test -Xswiftc -DENABLE_TESTING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: can we inspect the output and ensure it's not empty? I'm asking is this would not have caught the issue reported by:
🚨 WIP
Adds smoke tests to mirror https://github.com/compnerd/swift-build/blob/ded40b493386a049d73273e63f0c96ccceb79419/.github/workflows/swift-toolchain.yml#L5564