Runtimes: allow to link ClientRetainRelease in swiftCore #85367
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we are not building that natively in the new build system, so find the copy built by the legacy one using a find module. Addresses rdar://164174616
edymtt
requested review from
compnerd,
etcwilde and
justice-adams-apple
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please build toolchain Windows |
edymtt
commented
Nov 7, 2025
| target_link_libraries(swiftCore PRIVATE "${EXECINFO_LIBRARY}") | ||
| endif() | ||
|
|
||
| check_compiler_flag(Swift "-Xfrontend -enable-client-retain-release" HAVE_Swift_EMIT_CLIENT_RETAIN_RELEASE_FLAG) |
Contributor
Author
There was a problem hiding this comment.
This check will likely need to be generalized to all of Core, Overlay and Supplemental -- this may require a bit of staging, so it could make sense to land the find module first and wire it up in subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we are not building that natively in the new build system, so find the copy built by the legacy one using a find module.
Addresses rdar://164174616