Enable GenericSpecializer for borrow/mutate accessors and fix it for conditionally copyable types #86155
+197
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
requested review from
eeckstein,
jckarter and
kavon
as code owners
Contributor
Author
|
@swift-ci test |
Non trivial types can become trivial on generic specialization. OSSA has instructions that are valid for non-trivial types only: load_borrow/end_borrow, load [copy]/[take], store [init]/[assign], copy_value, destroy_value etc Transform such instructions to their trivial counterparts while cloning to prevent asserts firing.
meg-gupta
force-pushed
the
removeborrowoptbailouts
branch
from
a5c0a08 to
166a698
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in commits.