[IDE] Reference appendInterpolation calls in string interpolation #86166
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hamishknight @rintaro Can I please get a review on this? |
hamishknight
reviewed
Jan 9, 2026
Contributor
hamishknight
left a comment
hamishknight
left a comment
There was a problem hiding this comment.
I think we ought to see if we can handle this more generally
Contributor
Author
|
@hamishknight Yep, that general approach looks cleaner, which the small wrinkle that we need a check for ConstructorDecl now. |
hamishknight
reviewed
Jan 9, 2026
Contributor
hamishknight
left a comment
hamishknight
left a comment
There was a problem hiding this comment.
One more comment, LGTM otherwise
Fix missing references to `appendInterpolation` functions called implicitly in string interpolations. Fixes swiftlang#56189
hamishknight
approved these changes
Jan 10, 2026
Contributor
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing references to
appendInterpolationfunctions called implicitly in string interpolations.Fixes #56189