swiftly-install.sh Handle paths containing spaces
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're in the process of moving the installation logic out of the shell script and into swiftly itself, which should fix the spacing issue since the Swift built-in path handling is immune to this kind of problem in shell scripts. See #127 for more details. |
|
Now that #127 has been merged we can probably close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #134, the installer does not work on MacOS because of the space in the
$HOME/Library/Application Support/swiftlypath.The first problem was that bash function calls split arguments by spaces. Using
$@instead of$1fixed this.Then the path added to the
sourcecommands needed to be quoted.I don't know what effect these changes will have when run on Linux.