Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly Test: Language Client Integration Suite - Expand Macro test failed on Linux (nightly-main - jammy) #1315

Closed
rbenegal opened this issue Jan 15, 2025 · 2 comments
Closed

Nightly Test: Language Client Integration Suite - Expand Macro test failed on Linux (nightly-main - jammy) #1315

rbenegal opened this issue Jan 15, 2025 · 2 comments
Assignees
@rbenegal
Labels
testing infrastructure Issues related to CI jobs or extension test cases

Comments

@rbenegal
Copy link
Contributor

The Expand Macro test failed in the nightly run with:

  Language Client Integration Suite @slow
Language client is not ready yet. Retrying in 100 ms...
Language client is not ready yet. Retrying in 100 ms...
    1) Expand Macro
Captured logs during Language Client Integration Suite @slow → Expand Macro:
00:34:27: Activating Swift for Visual Studio Code...
00:34:27: Swift version 6.2-dev (LLVM 81859ac55f8d09a, Swift 8ec8a1229a7ea14)
Platform: linux
Swift Path: /usr/bin
Toolchain Path: /usr
Runtime Library Path: /usr/lib/swift/linux
Default Target: x86_64-unknown-linux-gnu
00:34:27: SourceKit-LSP setup
00:34:27: focus: undefined
00:34:27: test/defaultPackage: add: /tmp/code/assets/test/defaultPackage

...

rejected promise not handled within 1 second: Error: Timed out waiting for sourcekit-lsp document to be opened.
stack trace: Error: Timed out waiting for sourcekit-lsp document to be opened.
    at Timeout._onTimeout (/tmp/code/test/integration-tests/language/LanguageClientIntegration.test.ts:110:24)
    at listOnTimeout (node:internal/timers:581:17)
    at processTimers (node:internal/timers:519:7)

Link to failed run: https://github.com/swiftlang/vscode-swift/actions/runs/12778956212/job/35622745761

Seems like it was passing fine previously, so possibly just flaky.
@award999 award999 added the testing infrastructure Issues related to CI jobs or extension test cases label Jan 15, 2025
@award999 award999 moved this from Unscreened to In Progress in Swift Extension for Visual Studio Code Jan 16, 2025
@rbenegal
Copy link
Contributor Author

Failed again in https://github.com/swiftlang/vscode-swift/actions/runs/12848727861/job/35826444826:

 1) Language Client Integration Suite @slow
       Expand Macro:
     Error: Unknown error: no edits reported for semantic refactoring action for url file:///tmp/code/assets/test/swift-macro/Sources/swift-macroClient/main.swift
      at handleResponse (node_modules/vscode-jsonrpc/lib/common/connection.js:565:48)
      at handleMessage (node_modules/vscode-jsonrpc/lib/common/connection.js:345:13)
      at processMessageQueue (node_modules/vscode-jsonrpc/lib/common/connection.js:362:17)
      at Immediate.<anonymous> (node_modules/vscode-jsonrpc/lib/common/connection.js:334:13)
      at processImmediate (node:internal/timers:483:21)

Will look into removing/disabling this portion of the test for now. I think there is a lot going on when the test tries to build swift-macro, such as downloads from github, which will result in some flakiness for the test (similar to #1316). We should probably use some other technique that avoids depending on github and builds things faster to test this functionality.

rbenegal added a commit to rbenegal/vscode-swift that referenced this issue Jan 21, 2025
@rbenegal
Remove Expand Macro Test
0d3c4f2 
Currently, it seems like the Expand Macros test has some issues that
makes it fail intermittently when run on GitHub actions. These issues
seem to be hard to reproduce and likely require simplifying the
dependencies the test depends on. Remove the tests until there is a
better way to test this to avoid noise.

Issue: swiftlang#1315
rbenegal added a commit to rbenegal/vscode-swift that referenced this issue Jan 21, 2025
@rbenegal
Remove Expand Macro Test
296550e 
Currently, it seems like the Expand Macros test has some issues that
makes it fail intermittently when run on GitHub actions. These issues
seem to be hard to reproduce and likely require simplifying the
dependencies the test depends on. Remove the test until there is a
better way to test this to avoid noise.

Issue: swiftlang#1315
@rbenegal rbenegal mentioned this issue Jan 21, 2025
Merged
award999 pushed a commit that referenced this issue Jan 21, 2025
@rbenegal
Remove Expand Macro Test (#1324)
226e1f8 
Currently, it seems like the Expand Macros test has some issues that
makes it fail intermittently when run on GitHub actions. These issues
seem to be hard to reproduce and likely require simplifying the
dependencies the test depends on. Remove the test until there is a
better way to test this to avoid noise.

Issue: #1315
@award999
Copy link
Contributor

Verified

@award999 award999 moved this from In Progress to Done in Swift Extension for Visual Studio Code Jan 21, 2025
@award999 award999 mentioned this issue Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbenegal rbenegal

Labels
testing infrastructure Issues related to CI jobs or extension test cases
Projects
Swift Extension for Visual Studio Code
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@award999 @rbenegal