Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob 7.2.3 is deprecated #974

Closed
adam-fowler opened this issue Jul 18, 2024 · 3 comments · Fixed by #984
Closed

glob 7.2.3 is deprecated #974

adam-fowler opened this issue Jul 18, 2024 · 3 comments · Fixed by #984

Comments

@adam-fowler
Copy link
Contributor

Warning from npm install

npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

We didn't allow major updates on glob because it broke the tests. Looks like we can remove this dependency now though

@plemarquand
Copy link
Contributor

These warnings are not totally under our control since they get reported even when installing dependencies of our dependencies. For instance we depend on @vscode/vsce, which still depends on glob 7.0.6. We get a deprecation warning about that.

@adam-fowler
Copy link
Contributor Author

Currently we are referencing "glob": "~7.2.3" in the devDependencies, maybe we should remove it if we aren't using it. It looks like the test code reliant on it has been removed

@plemarquand
Copy link
Contributor

plemarquand commented Jul 18, 2024

Here are a few issues in dependencies we're using that track glob deprecation:
mochajs/mocha#5148
microsoft/vscode-vsce#1026

vscode-test-cli also uses an outdated c8 that depends on a version of test-exclude that uses a deprecated version of glob: https://github.com/bcoe/c8/blob/main/package.json#L43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants