Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glob 7.* is going EOL #1026

Closed
pelikhan opened this issue Jul 18, 2024 · 1 comment · Fixed by #1027
Closed

glob 7.* is going EOL #1026

pelikhan opened this issue Jul 18, 2024 · 1 comment · Fixed by #1027
Assignees
@benibenj
Labels
dependencies Pull requests that update a dependency file

Comments

@pelikhan
Copy link
Member

Warning when installing on node 20

warning @vscode/vsce > glob@7.2.3: Glob versions prior to v9 are no longer supported
@benibenj benibenj self-assigned this Jul 18, 2024
@benibenj benibenj added the dependencies Pull requests that update a dependency file label Jul 18, 2024
@plemarquand
Copy link

Aside from using an outdated glob directly, @vscode/vsce also depends on tmp@^0.2.1, which in turn relies on rimraf 3.0.2, which depends on glob 7.1.3. Updating tmp to 0.2.3 fixes this dependency chain.

@plemarquand plemarquand mentioned this issue Jul 18, 2024
Closed
@benibenj benibenj mentioned this issue Jul 19, 2024
Merged
@wesbillman wesbillman mentioned this issue Aug 23, 2024
Merged
github-merge-queue bot pushed a commit to TBD54566975/ftl that referenced this issue Aug 23, 2024
@wesbillman
fix: vscode extension build errors with glob (#2491)
cbe0dc4 
Fixes #2486 

microsoft/vscode-vsce#1026
github-merge-queue bot pushed a commit to TBD54566975/ftl that referenced this issue Aug 24, 2024
@wesbillman
fix: vscode extension build errors with glob (#2491)
33c8e04 
Fixes #2486 

microsoft/vscode-vsce#1026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibenj benibenj

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update deprecated dependencies microsoft/vscode-vsce
3 participants
@plemarquand @pelikhan @benibenj