Add integration tests for package dependencies #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weng
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
requested changes
Oct 18, 2024
michael-weng
force-pushed
the
local_dep_itest
branch
from
f1694d5
to
94040e0
Compare
award999
requested changes
Oct 25, 2024
michael-weng
force-pushed
the
local_dep_itest
branch
3 times, most recently
from
fb053bf
to
435210e
Compare
michael-weng
force-pushed
the
local_dep_itest
branch
3 times, most recently
from
1c2b660
to
bb37883
Compare
michael-weng
force-pushed
the
local_dep_itest
branch
from
2009649
to
b7ec69c
Compare
award999
requested changes
Nov 7, 2024
award999
approved these changes
Nov 7, 2024
award999
approved these changes
Nov 8, 2024
- Verify various contract calls with spm - Exercises use local version workflow Issue: swiftlang#1052
- Switch to assert directly on executeCommand return
- Move tests to a more appropriate location under integration-tests/commands
- Rename to CONSTANT_CASE for module level enums' value
between toolchains above 5.9 and 5.9 + below. - Move to a spot where spm update is guranteed to return 0, after local dependency is fully set up.
- Unified return for the dependencies command to return boolean
desired behaviour.
michael-weng
force-pushed
the
local_dep_itest
branch
from
c3f811d
to
64ca693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1052