Pick highest installed MSVC version #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
force-pushed
the
debug-failing-windows-again
branch
3 times, most recently
from
2e26f11 to
4298af6
Compare
plemarquand
changed the title
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
GitHub keeps changing the builder image out from under us. In this case it looks like they moved it back to the old version we had before. To try and ease the pain simply pick the highest installed MSVC version.
plemarquand
force-pushed
the
debug-failing-windows-again
branch
from
4298af6 to
96df761
Compare
rbenegal
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub keeps changing the builder image out from under us. In this case it looks like they moved it back to the old version we had before.
To try and ease the pain simply pick the highest installed MSVC version.