Mark tests as skipped when they fail to compile #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
If there is a compilation error when compiling the tests for a test run show the tests that were expected to be part of the run as "skipped" and associated the build output (with the build failure) with the test items. The goal is to make it clear that these tests were not run due to a build error.
plemarquand
force-pushed
the
better-test-failure-reporting
branch
from
7019841 to
2c19079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a compilation error when compiling the tests for a test run show the tests that were expected to be part of the run as "skipped" and associated the build output (with the build failure) with the test items. The goal is to make it clear that these tests were not run due to a build error.