Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlay hints Provider v2 #199

Merged
merged 6 commits into from
Mar 31, 2022
Merged

Conversation

adam-fowler
Copy link
Contributor

@adam-fowler adam-fowler commented Mar 18, 2022

Up to this point Inlay hints have had a custom renderer. With version 1.65.0 of VSCode was released an official Inlay hints renderer. This PR moves the Inlay hints code to use that.

Note this PR requires people to upgrade to v1.65.0 of VSCode

@adam-fowler
Copy link
Contributor Author

@swift-server-bot test this please

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see PRs with more lines removed than added! 🎉

@adam-fowler adam-fowler merged commit fa11267 into swiftlang:main Mar 31, 2022
@adam-fowler adam-fowler deleted the inlay-hints branch March 31, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace InlayHints with official provider
2 participants