Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languageclient v8 #314

Merged
merged 3 commits into from
May 27, 2022
Merged

Conversation

adam-fowler
Copy link
Contributor

@adam-fowler adam-fowler commented May 24, 2022

- client.onReady() does not exist anymore instead client.start is async so store promise returned by client.start and use that instead of onReady().
- Create a new client when restarting. Stopping, setting the workspace folder and starting doesn't work anymore
It is no longer used
@adam-fowler adam-fowler requested a review from 0xTim May 25, 2022 19:31
@adam-fowler adam-fowler merged commit eeb59db into swiftlang:main May 27, 2022
@adam-fowler adam-fowler deleted the languageclient-v8 branch May 27, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants