Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedArray improvement? #52

Closed
j-f1 opened this issue Sep 15, 2020 · 1 comment · Fixed by #58
Closed

TypedArray improvement? #52

j-f1 opened this issue Sep 15, 2020 · 1 comment · Fixed by #58
Labels
enhancement New feature or request

Comments

@j-f1
Copy link
Member

j-f1 commented Sep 15, 2020

Currently, creating a TypedArray using swjs_create_typed_array requires passing an enumerated value, JavaScriptTypedArrayKind, to determine which kind of typed array should be created. I don’t remember exactly why I did this — would it make more sense to just pass a reference to the constructor function for the particular typed array we want?
@j-f1 j-f1 added the enhancement New feature or request label Sep 15, 2020
@kateinoigakukun
Copy link
Member

It seems better way. 👍

@j-f1 j-f1 mentioned this issue Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove JavaScriptTypedArrayKind swiftwasm/JavaScriptKit
2 participants
@kateinoigakukun @j-f1