Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example code in README.md #100

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Update example code in README.md #100

merged 1 commit into from
Oct 21, 2020

Conversation

MaxDesiatov
Copy link
Contributor

It was my mistake to convert the example code to the new style without checking it in a real app, turns out there were a few errors in the converted version.

Calling alert on JSObject.global still requires force unwrapping. Also, dynamic properties can't be updated on JSValue constants, so need to convert divElement to a var binding.

It was my mistake to convert the example code to the new style without checking it in a real app, turns out there were a few errors in the converted version.

Calling `alert` on `JSObject.global` still requires force unwrapping. Also, dynamic properties can't be updated on `JSValue` constants, so need to convert `divElement` to a `var` binding.
@MaxDesiatov MaxDesiatov requested review from kateinoigakukun and a team October 21, 2020 09:54
@github-actions
Copy link

Time Change: +201ms (1%)

Total Time: 10,082.75ms

Test name Duration Change
Object heap/Increment and decrement RC 3,084.25ms +166.5ms (5%) 🔍
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 179.75ms -0.5ms
Serialization/Write JavaScript string directly 186ms -3.75ms (2%)
Serialization/Swift Int to JavaScript 3,280.75ms +13.5ms (0%)
Serialization/Swift String to JavaScript 3,352ms +25.25ms (0%)

performance-action

@MaxDesiatov MaxDesiatov merged commit 0cbb857 into main Oct 21, 2020
@MaxDesiatov MaxDesiatov deleted the fix-readme-example branch October 21, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants