Major API change on JSClosure #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `JSOneshotClosure` which provide an ability to invoke a closure at most once. - Remove `JSClosure.init(_ body: @escaping ([JSValue]) -> Void)` overload, which forces users to write result type in closure. - Add JSClosure lifetime test suites
kateinoigakukun
force-pushed
the
katei/update-jsclosure
branch
from
bde6914
to
4c9b876
Compare
|
Time Change: -525.25ms (6%) ✅ Total Time: 8,162ms
ℹ️ View Unchanged
|
MaxDesiatov
reviewed
Jan 2, 2021
MaxDesiatov
reviewed
Jan 2, 2021
MaxDesiatov
reviewed
Jan 2, 2021
MaxDesiatov
reviewed
Jan 2, 2021
Co-authored-by: Max Desiatov <max@desiatov.com>
MaxDesiatov
approved these changes
Jan 2, 2021
|
@swiftwasm/jskit-team Could anyone review this change? I want two or more approvals for this kind of API change before merging 🙏 |
j-f1
reviewed
Jan 3, 2021
Co-authored-by: Jed Fox <git@jedfox.com>
j-f1
reviewed
Jan 3, 2021
Co-authored-by: Jed Fox <git@jedfox.com>
|
@j-f1 I addressed reviewed points. Could you take a look again? |
j-f1
reviewed
Jan 3, 2021
Comment on lines
+506
to
+509
| timeout = JSTimer(millisecondsDelay: timeoutMilliseconds, isRepeating: false) { | ||
| fatalError("timer should be cancelled") | ||
| } | ||
| timeout = nil |
There was a problem hiding this comment.
Totally happy to punt this to another issue, but since there isn’t necessarily a need to cancel a setTimeout, could there be an API that doesn’t require holding the JSTimer instance? I guess users could just do
JSObject.global.setTimeout(JSOneshotClosure {
// ...
return undefined
}, 1000)There was a problem hiding this comment.
Yes, we can provide such API in this signature for example.
JSTimer.timeout(millisecondsDelay: 100) {
// ...
}This PR is already too large, so let's implement it in another PR 👍
Co-authored-by: Jed Fox <git@jedfox.com>
jed-fox-neeva
approved these changes
Jan 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While integrating async/await feature, I found
JSPromisehas too complex API. (e.g. too many overloads, unsafe generic parameters, and lifetime management)So I want to refine the API before async/await integration. As a first step, I changed
JSClosureAPI.Changes
JSOneshotClosurewhich provides an ability to invoke a closure at most once. This will be suitable to use with functions likePromise.thenJSClosure.init(_ body: @escaping ([JSValue]) -> Void)overload, which forces users to write result type in closure.