Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gardening tests #133

Merged
merged 7 commits into from
Jul 18, 2021
Merged

Gardening tests #133

merged 7 commits into from
Jul 18, 2021

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jul 18, 2021 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Jul 18, 2021 •
edited
Loading

Time Change: +157.75ms (1%)

Total Time: 10,526ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 207ms +3.5ms (1%)
Serialization/Write JavaScript string directly 205.5ms -1ms
Serialization/Swift Int to JavaScript 3,341.25ms +89.75ms (2%)
Serialization/Swift String to JavaScript 3,430.75ms +25.25ms (0%)
Object heap/Increment and decrement RC 3,341.5ms +40.25ms (1%)

performance-action

MaxDesiatov
MaxDesiatov reviewed Jul 18, 2021
View reviewed changes
IntegrationTests/TestSuites/Sources/PrimaryTests/main.swift
@@ -200,7 +200,9 @@ try test("Closure Lifetime") {
}
c1.release()
// Call a released closure
print("======= BEGIN OF EXPECTED FATAL ERROR =====")
_ = try expectThrow(try evalClosure.throws(c1))
Copy link
Contributor

@MaxDesiatov MaxDesiatov Jul 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should expectThrow contain these prints to avoid repetition?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expectThrow is not for crash tests, so I added another helper function

MaxDesiatov
MaxDesiatov approved these changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, thanks!

@kateinoigakukun kateinoigakukun merged commit 7f41fb4 into main Jul 18, 2021
@kateinoigakukun kateinoigakukun deleted the katei/gardening-tests branch July 18, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make test crashes due to JSClosure memory issues
2 participants
@kateinoigakukun @MaxDesiatov