Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental global executor cooperating with JS event loop #141

Merged
merged 6 commits into from
Oct 3, 2021

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 3, 2021

This is a replacement of #137 to follow the latest implementation of Concurrency runtime.

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

Time Change: -149.25ms (1%)

Total Time: 10,253.5ms

Test name Duration Change
Serialization/Write JavaScript number directly 212.5ms -22.25ms (10%) 👏
Serialization/Write JavaScript string directly 239ms +34.5ms (14%) ⚠️
ℹ️ View Unchanged
Test name Duration Change
Serialization/Swift Int to JavaScript 3,232ms -117.5ms (3%)
Serialization/Swift String to JavaScript 3,346ms +107.5ms (3%)
Object heap/Increment and decrement RC 3,224ms -151.5ms (4%)

performance-action

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment typo nit

Sources/JavaScriptEventLoop/JavaScriptEventLoop.swift Outdated Show resolved Hide resolved
@kateinoigakukun kateinoigakukun marked this pull request as ready for review October 3, 2021 23:51
@kateinoigakukun kateinoigakukun merged commit b9a2573 into main Oct 3, 2021
@kateinoigakukun kateinoigakukun deleted the katei/js-serial-executor branch October 3, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants