Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macOS Monterey requirement from Package.swift #144

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Nov 22, 2021

This currently prevents Tokamak from being built on macOS 11 or earlier macOS versions. I think the original concern is no longer an issue, where back-deployment with Xcode 13.2 to old macOS versions will become available really soon. In fact, beta versions of Xcode 13.2 are already available on GitHub Actions if we need to test with those.

@MaxDesiatov MaxDesiatov requested a review from a team November 22, 2021 13:41
@github-actions
Copy link

github-actions bot commented Nov 22, 2021

Time Change: +271.25ms (2%)

Total Time: 10,477.5ms

Test name Duration Change
Serialization/Swift Int to JavaScript 3,480.25ms +334ms (9%) 🔍
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 208.75ms +3.5ms (1%)
Serialization/Write JavaScript string directly 207.75ms -0.75ms
Serialization/Swift String to JavaScript 3,102.75ms -84.75ms (2%)
Object heap/Increment and decrement RC 3,478ms +19.25ms (0%)

performance-action

@kateinoigakukun
Copy link
Member

In theory, SwiftPM should ignore that requirement when building for macOS because JavaScriptKit is declared as an optional dependency in Tokamak only for wasm32-unknown-wasi.
But for now, it's ok to remove the requirement. We need to describe that users need to add .unsafeFlags(["-Xfrontend", "-disable-availability-checking"]) in their Package.swift to develop on Xcode under macOS 11.

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Nov 22, 2021

@kateinoigakukun Would mentioning that Xcode 13.2 is required for development of macOS apps depending on JavaScriptKit be enough?

That way users wouldn't have to add any flags manually.

@kateinoigakukun
Copy link
Member

I think it's too early to always require Xcode 13.2 for JSKit development, so it's better to mention both options.

@MaxDesiatov
Copy link
Contributor Author

Great, I've added a clarification to README.md. Also added full concurrency example there to make it more obvious why we have these weird Xcode/macOS requirements 😅

@MaxDesiatov MaxDesiatov merged commit 286f8ec into main Nov 22, 2021
@MaxDesiatov MaxDesiatov deleted the remove-monterey-requirement branch November 22, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants