Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TypedArray.set to copy a bunch of bytes #146

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Use TypedArray.set to copy a bunch of bytes #146

merged 1 commit into from
Dec 5, 2021

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 4, 2021 •
edited
Loading

Time Change: -187ms (2%)

Total Time: 7,819ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 170.5ms +3.25ms (1%)
Serialization/Write JavaScript string directly 174.25ms +0.5ms
Serialization/Swift Int to JavaScript 2,383ms -85.5ms (3%)
Serialization/Swift String to JavaScript 2,478.75ms -89ms (3%)
Object heap/Increment and decrement RC 2,612.5ms -16.25ms (0%)

performance-action

j-f1
j-f1 approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kateinoigakukun kateinoigakukun merged commit e2c14a1 into main Dec 5, 2021
@kateinoigakukun kateinoigakukun deleted the katei/use-typedarray-set branch December 5, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @j-f1