Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return from runtime functions instead of taking a pointer where possible #147

Merged
merged 6 commits into from
Jan 3, 2022

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Jan 3, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Time Change: -187.75ms (2%)

Total Time: 8,062.75ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 172.75ms +2.5ms (1%)
Serialization/Write JavaScript string directly 175ms +0.75ms
Serialization/Swift Int to JavaScript 2,477.25ms -71.25ms (2%)
Serialization/Swift String to JavaScript 2,565.25ms -82.75ms (3%)
Object heap/Increment and decrement RC 2,672.5ms -37ms (1%)

performance-action

Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump up library version in swjs_library_version because this change breaks runtime library compatibility?

@j-f1
Copy link
Member Author

j-f1 commented Jan 3, 2022

Done!

@kateinoigakukun kateinoigakukun merged commit 1034940 into main Jan 3, 2022
@kateinoigakukun kateinoigakukun deleted the jed/return-from-new branch January 3, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants