Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async JSPromise.result property #200

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Add async JSPromise.result property #200

merged 1 commit into from
Jul 19, 2022

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jul 19, 2022 •
edited
Loading

Add JSPromise.result, which is similar with Task.result

@kateinoigakukun kateinoigakukun requested a review from a team July 19, 2022 06:57
@github-actions
Copy link

Time Change: -172ms (0%)

Total Time: 17,509ms

Test name Duration Change
Serialization/Write JavaScript number directly 391ms -44ms (11%) 👏
Serialization/Write JavaScript string directly 436ms -41ms (9%) ✅
View Unchanged
Test name Duration Change
Serialization/Swift Int to JavaScript 5,535ms -63ms (1%)
Serialization/Swift String to JavaScript 5,718ms -62ms (1%)
Object heap/Increment and decrement RC 5,430ms +38ms (0%)

MaxDesiatov
MaxDesiatov approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit 901de66 into main Jul 19, 2022
@kateinoigakukun kateinoigakukun deleted the katei/jspromise-result branch July 19, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@yonihemi yonihemi yonihemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kateinoigakukun @MaxDesiatov @yonihemi