-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime Performance Optimization #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time Change: -3,602ms (19%) 👏 Total Time: 18,757ms
View Unchanged
|
kateinoigakukun
force-pushed
the
katei/perf-opt
branch
from
August 16, 2022 16:52
64af28e
to
bffe009
Compare
sunnypp
reviewed
Aug 17, 2022
kateinoigakukun
force-pushed
the
katei/perf-opt
branch
from
August 18, 2022 06:01
bc51ac6
to
a1b690e
Compare
MaxDesiatov
reviewed
Aug 18, 2022
MaxDesiatov
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, these are very impressive improvements! 👏
I only have a couple of suggestions for improving doc comments, but otherwise this LGTM.
kateinoigakukun
force-pushed
the
katei/perf-opt
branch
from
August 18, 2022 15:23
745f3c6
to
a9843ee
Compare
MaxDesiatov
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory
anddataView
getter in runtime TS code