Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove baseline tests (e.g. “Call JavaScript function directly”) from comparison #211

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Sep 19, 2022

See below comment for an example. Changes to speed in these tests is not at all useful for us to track since they’re directly related to the speed of the JS engine, and are just a target for us to one day match.

@github-actions
Copy link

Time Change: +79ms (0%)

Total Time: 17,900ms

View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 23ms -0ms
Serialization/JavaScript function call through Wasm import with int 19ms -1ms
Serialization/JavaScript function call from Swift 189ms -2ms (1%)
Serialization/Swift Int to JavaScript with assignment 442ms +8ms (1%)
Serialization/Swift Int to JavaScript with call 1,372ms +42ms (3%)
Serialization/JavaScript Number to Swift Int 461ms +1ms (0%)
Serialization/Swift String to JavaScript with assignment 508ms +4ms (0%)
Serialization/Swift String to JavaScript with call 1,472ms +43ms (2%)
Serialization/JavaScript String to Swift String 5,757ms +64ms (1%)
Object heap/Increment and decrement RC 7,639ms -79ms (1%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 7ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 3ms

@j-f1 j-f1 requested a review from a team September 19, 2022 15:54
@kateinoigakukun kateinoigakukun merged commit 73cdff2 into main Sep 20, 2022
@kateinoigakukun kateinoigakukun deleted the separate-baselines branch September 20, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants