Add JavaScriptEventLoopTestSupport module to install executor #213

kateinoigakukun · 2022-09-30T12:48:07Z

No description provided.

github-actions · 2022-09-30T13:48:17Z

Time Change: +31ms (0%)

Total Time: 22,482ms

Test name	Duration	Change
Serialization/JavaScript function call through Wasm import	28ms	-6ms (21%)	🎉
Serialization/JavaScript function call through Wasm import with int	25ms	-3ms (10%)	👏

View Unchanged

Test name	Duration	Change
Serialization/JavaScript function call from Swift	248ms	+12ms (4%)
Serialization/Swift Int to JavaScript with assignment	546ms	-2ms (0%)
Serialization/Swift Int to JavaScript with call	1,638ms	+8ms (0%)
Serialization/JavaScript Number to Swift Int	598ms	+23ms (3%)
Serialization/Swift String to JavaScript with assignment	635ms	-4ms (0%)
Serialization/Swift String to JavaScript with call	1,770ms	-2ms (0%)
Serialization/JavaScript String to Swift String	7,018ms	-99ms (1%)
Object heap/Increment and decrement RC	9,959ms	+111ms (1%)

View Baselines

Test name	Duration
Serialization/Call JavaScript function directly	2ms
Serialization/Assign JavaScript number directly	3ms
Serialization/Call with JavaScript number directly	5ms
Serialization/Write JavaScript string directly	3ms
Serialization/Call with JavaScript string directly	3ms

and it expects at least having one argument

because Node.js's WASI implementatin does't supprot proc_exit in async reactor model. See https://github.com/nodejs/node/blob/2a4452a53af65a13db4efae474162a7dcfd38dd5/lib/wasi.js#L121

kateinoigakukun · 2022-09-30T14:21:48Z

Thank you for quick review :)

kateinoigakukun added 8 commits September 30, 2022 13:52

Add JavaScriptEventLoopTestSupport module to install executor

f72b207

Add short document about JavaScriptEventLoopTestSupport

6fea6e5

Publish JavaScriptEventLoopTestSupport as a product

d82c70f

Add arg0 to wasi arguments because XCTest reads process arguments

eb9d9f2

and it expects at least having one argument

Exit process when proc_exit is called on Node.js WASI

28bb7f2

because Node.js's WASI implementatin does't supprot proc_exit in async reactor model. See https://github.com/nodejs/node/blob/2a4452a53af65a13db4efae474162a7dcfd38dd5/lib/wasi.js#L121

Add unit test target for JavaScriptEventLoopTestSupport

08c36d2

Add unit test job in Makefile

0c39b24

Add API guard directives for native build

3e94df2

kateinoigakukun force-pushed the katei/add-jsel-test-support branch from ef397f4 to 6cdac18 Compare September 30, 2022 14:01

Run async unit tests only with 5.7 toolchain

b34c15f

kateinoigakukun force-pushed the katei/add-jsel-test-support branch from 6cdac18 to b34c15f Compare September 30, 2022 14:03

j-f1 approved these changes Sep 30, 2022

View reviewed changes

kateinoigakukun merged commit a549f58 into main Sep 30, 2022

kateinoigakukun deleted the katei/add-jsel-test-support branch September 30, 2022 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JavaScriptEventLoopTestSupport module to install executor #213

Add JavaScriptEventLoopTestSupport module to install executor #213

kateinoigakukun commented Sep 30, 2022

github-actions bot commented Sep 30, 2022 •

edited

Loading

kateinoigakukun commented Sep 30, 2022

Add JavaScriptEventLoopTestSupport module to install executor #213

Add JavaScriptEventLoopTestSupport module to install executor #213

Conversation

kateinoigakukun commented Sep 30, 2022

github-actions bot commented Sep 30, 2022 • edited Loading

kateinoigakukun commented Sep 30, 2022

github-actions bot commented Sep 30, 2022 •

edited

Loading