Fix JSClosure leak
#240
Merged
Fix JSClosure leak
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```swift
let c1 = JSClosure { _ in .undefined }
consume c1
```
did not release the `JSClosure` itself and it leaked the underlying
JavaScript closure too because `JSClosure` -> JS closure thunk ->
Closure registry entry -> `JSClosure` reference cycle was not broken
when using FinalizationRegistry. (Without FR, it was broken by manual
`release` call.)
Note that weakening the reference does not violates the contract that
function reference should be unique because holding a weak reference does
deinit but not deallocate the object, so ObjectIdentifier is not reused
until the weak reference in the registry is removed.
The test suite was not properly releasing the closures but they have not been revealed as a problem because those closures were leaked conservatively.
…tract This additional information will help developers to find the root cause
|
Time Change: +325ms (3%) Total Time: 9,697ms
View Unchanged
View Baselines
|
|
Tested with a random large-scale application and no major regression found |
kateinoigakukun
added a commit
that referenced
this pull request
Apr 12, 2024
kateinoigakukun
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did not release the
JSClosureitself and it leaked the underlyingJavaScript closure too because
JSClosure-> JS closure thunk ->Closure registry entry ->
JSClosurereference cycle was not brokenwhen using FinalizationRegistry. (Without FR, it was broken by manual
releasecall.)Note that weakening the reference does not violates the contract that
function reference should be unique because holding a weak reference does
deinit but not deallocate the object, so ObjectIdentifier is not reused
until the weak reference in the registry is removed.