Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start migrating imported functions to the new definition style #252

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

kateinoigakukun
Copy link
Member

Use of different function names for C-name and Wasm's import name is a bit confusing. Also use of unprefixed function names in the C code is not a good practice. This commit starts migrating imported functions to the new naming convention and removes duplicated function definitions just for IDE support by using macro.

Use of different function names for C-name and Wasm's import name is a
bit confusing. Also use of unprefixed function names in the C code is
not a good practice. This commit starts migrating imported functions to
the new naming convention and removes duplicated function definitions
just for IDE support by using macro.
Copy link

github-actions bot commented Jun 11, 2024

Time Change: -394ms (4%)

Total Time: 9,416ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 20ms -1ms (5%)
Serialization/Swift String to JavaScript with assignment 387ms -33ms (8%)
Serialization/Swift String to JavaScript with call 985ms -50ms (5%)
Serialization/JavaScript String to Swift String 3,698ms -259ms (7%)
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 15ms +1ms
Serialization/JavaScript function call from Swift 104ms +0ms
Serialization/Swift Int to JavaScript with assignment 320ms -14ms (4%)
Serialization/Swift Int to JavaScript with call 946ms -36ms (3%)
Serialization/JavaScript Number to Swift Int 300ms -11ms (3%)
Object heap/Increment and decrement RC 2,629ms +15ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 4ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 2ms
Serialization/Call with JavaScript string directly 2ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review June 11, 2024 11:13
@kateinoigakukun kateinoigakukun enabled auto-merge (squash) June 11, 2024 11:13
@kateinoigakukun kateinoigakukun merged commit 2bb0694 into main Jun 11, 2024
17 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/refactor-import-funcs branch June 11, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant