Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add void-returning overload to JSClosure.init #34

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

MaxDesiatov
Copy link
Contributor

This is a great idea that @j-f1 posted in comments elsewhere: most of the time JSClosure instances return .undefined, so this is a common case that can be simplified with a corresponding overload.

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label Aug 11, 2020
@kateinoigakukun kateinoigakukun merged commit 9d4d950 into master Aug 11, 2020
@kateinoigakukun kateinoigakukun deleted the jsclosure-void-init branch August 11, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants