Add JSError with tests, add JSObject.description #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Sep 13, 2020
| public var name: String { | ||
| ref.name.string! | ||
| } | ||
| } |
There was a problem hiding this comment.
Although it’s not standard, all engines that I know of implement error.stack to provide a stack trace as a string. It might be useful to access it.
kateinoigakukun
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSErrorwill be used in a future PR with aJSPromiseimplementation to make a statically typedcatchmethod available on it.While there's no straightforward way to throw
JSErrorfrom Swift code right now, I think this type might become useful in some other cases too in the future. Maybe we could find a way to catch an error from an arbitrary JavaScript function?JSObjectandJSErrorare alsoCustomStringConvertible, astoString()is available on all JavaScript objects according to the standard.